adding support for linux-ppc64le #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilhusain-s
force-pushed
the
linux-ppc64le
branch
from
4efe29c
to
f6bec8e
Compare
|
Hello @adilhusain-s , can you please add e2e test to make sure the action produces inux-ppc64le binaries and change the README to reflect new input values. |
dsame
added
feature request
dsame
approved these changes
Aug 11, 2023
dmitry-shibanov
approved these changes
Aug 14, 2023
marko-zivic-93
approved these changes
Aug 16, 2023
dsame
suggested changes
Aug 16, 2023
There was a problem hiding this comment.
Since 1.21.x both ppc64 and ppc64le are supported https://go.dev/dl/?mode=json&include=all and the PR can not be accepted in the current state.
It must be modified either to accept ppc64 and ppc64le arch or use ppc64 for ppc64le archtecture only for the go version below 1.21
|
Hello @adilhusain-s finally we went to conclusion there's no need in the PR since 1.21 supports both ppc64 and ppc64le and architectures can be used without the translation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Made changes to support linux-ppc64le arch
please review and merge.